Ticket #231 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Swish 073 - Error time file

Reported by: omoutret@touraine-logement.fr Owned by: anonymous
Priority: major (affects peripheral workflow) Milestone: 0.30 Better dialogues
Component: host folder Version: 0.7.3
Keywords: Cc:


With Swish, well as download the latest version 0.7.3, I get an error on the time files.
If I use another program like WinSCP or psftp (putty), I do not have the same timestamps.
Is there a setting to set for not having the time offset?


Re Swish 073 - Error time file.msg Download (123.5 KB) - added by omoutret@touraine-logement.fr 7 years ago.
073 error time - re: Alexander lamaison

Change History

Changed 7 years ago by omoutret@touraine-logement.fr

073 error time - re: Alexander lamaison

comment:1 Changed 7 years ago by alamaison

  • Owner changed from alamaison to anonymous
  • Status changed from new to accepted
  • Milestone set to 0.30 Better dialogues

comment:2 Changed 7 years ago by alamaison

  • Status changed from accepted to closed
  • Resolution set to fixed

In [a17c4b96a36ab4772e1ef0836bf47961a1fc878f/swish]:

Fix display of modified/accessed dates in local time zone.

Partially reverts 5227bd311291a7846d352938559e27525acb4cdf. That commit changed the code to convert the libssh2 UTC times into the local time zone. However, it appears that Explorer expects the OLE DATE (VT_DATE) variant to be in UTC format, so the timezone conversion is happening twice. Explorer's expectation isn't documented anywhere that we could find. The following docs for PropVariantToFileTime? is the closest we could find:  http://goo.gl/Z56FKb.

It's not clear why we thought commit 5227bd3 fixed #121 and #139 or why those bugs occurred at all. Perhaps a problem elsewhere, that has since been fixed, caused those problems and 5227bd3 masked it despite being the wrong fix. Hopefull this change won't reintroduce those bugs.

Relates #121.
Relates #139.
Fixes #231.

Note: See TracTickets for help on using tickets.